Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Federal to Tax revenues when budgetary impacts are split out #678

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

QianruZhang78
Copy link
Collaborator

@QianruZhang78 QianruZhang78 commented Aug 9, 2023

πŸ€– Generated by Copilot at c46b641

Summary

πŸ›πŸŒπŸ› οΈ

Fix tax column labels for non-US/Canada regions in BudgetaryImpact.jsx. This improves the app's internationalization and consistency.

tax labels change
only for US and Canada
autumn leaves fall

Walkthrough

  • Fix the logic for changing the tax column labels based on the region (link)

@QianruZhang78 QianruZhang78 linked an issue Aug 9, 2023 that may be closed by this pull request
@QianruZhang78
Copy link
Collaborator Author

@MaxGhenis Hello Max, I just created this new pull request as the last one linked to a wrong source branch, and yes now all tax revenues are specified as either state or federal outside the US, please check:)

@QianruZhang78 QianruZhang78 marked this pull request as ready for review August 9, 2023 14:17
@MaxGhenis
Copy link
Contributor

all tax revenues are specified as either state or federal outside the US

To clarify, here's what we want:

  • In US, always says State tax revenues or Federal tax revenues, never Tax revenues
  • Outside US, always says Tax revenues

Could you drop screenshots confirming this behavior?

@QianruZhang78
Copy link
Collaborator Author

QianruZhang78 commented Aug 10, 2023

@MaxGhenis I've updated the logic to achieve the behavior, please check:)
UK: "tax revenues"
Screen Shot 2023-08-10 at 3 03 05 PM
US: "state/federal tax revenues"
Screen Shot 2023-08-10 at 3 12 52 PM
Screen Shot 2023-08-10 at 3 23 04 PM

@MaxGhenis
Copy link
Contributor

MaxGhenis commented Aug 10, 2023

Thanks - results look good, just please reformat the code to pass CI. We might also have a list of US state codes in the app somewhere you could use. @nikhilwoodruff

@QianruZhang78
Copy link
Collaborator Author

@MaxGhenis I've reformatted the code to pass the test, and it still produces the same result. Below are the screenshots to confirm the behavior, please check:)
outside us:
Screen Shot 2023-08-11 at 2 39 08 PM
us:
Screen Shot 2023-08-11 at 2 40 03 PM
Screen Shot 2023-08-11 at 2 45 46 PM

@MaxGhenis MaxGhenis merged commit 6a7bc5d into master Aug 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Federal to Tax revenues when budgetary impacts are split out
2 participants